Idris is the prototypical glass half full/half empty career actor.
On one hand, everything about dude is A-list as far as acting, charisma, screen presence and having the "look" . Add to that he's been in a slew of big budget/popular movies, comic movies, Disney movies, etc. So with that perspective, he's had a great career.
On the other hand, he could never get the damn roles where he could actually propel himself as an actual A-list/mainstream lead. The Dark Tower is essentially being his first real chance after about a decade + of side roles. Typically it be stuff like his Prometheus role or that viking shyt in Thor. Pretty much him just making the best out of a limited situation. You'd have to turn to his Luther stuff or his independent/netflix movies to really see him shine.
He had a real break-out chance 5-6 years ago with the Alex Cross film but the director/studio head infamously booted him last minute to give the role to Tyler Perry, claiming you can't pass up on big budget guys like "Will Smith
and Tyler Perry..."
suffice to say, the movie flopped. Granted i heard the movie was so trash that maybe he actually dodge a bullet there.